Make repoPathRegex more permissive.#4439
Conversation
Codecov ReportBase: 88.55% // Head: 88.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 283 283
Lines 25533 25533
Branches 6879 6879
=======================================
Hits 22611 22611
Misses 2715 2715
Partials 207 207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It will now accept "revisions" which are git tag names. For example: git:github.com/torvalds/linux:arch/x86/mm/fault.c:v5.15 In this example, the tag name / "revision" is "v5.15". The CORS-URL for this file would then be https://raw.githubusercontent.com/torvalds/linux/v5.15/arch/x86/mm/fault.c
mstange
force-pushed
the
permissive-regex-for-git-rev
branch
from
79bf65a to
77886a3
Compare
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
I was initially planning to use it for kernel sources in samply, but then I noticed that Ubuntu has its own patches on top of the original kernel source, so I'll need to get the source from somewhere else after all.
Ah, that's unfortunate. But still it could be useful for other people or for us in the future for something else.
|
I did actually find another use for this: The symbolication response from a local |
2 participants
It will now accept "revisions" which are git tag names. For example:
git:github.com/torvalds/linux:arch/x86/mm/fault.c:v5.15In this example, the tag name / "revision" is "v5.15". The CORS-URL for this file would then be
https://raw.githubusercontent.com/torvalds/linux/v5.15/arch/x86/mm/fault.c
I'm not planning to use this capability, but maybe it'll be useful for somebody at some point.
I was initially planning to use it for kernel sources in samply, but then I noticed that Ubuntu has its own patches on top of the original kernel source, so I'll need to get the source from somewhere else after all.